Attribute object that supports units and comparison #4779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
preetapan
reviewed
Oct 15, 2018
| // Multiplier is the multiplier over the base unit (KiB multiplier is 1024) | ||
| Multiplier int64 | ||
|
|
||
| // InverseMultiplier specifies that the multiplier is an inverse so: |
There was a problem hiding this comment.
why not make the multiplier a float so it works for both cases?
preetapan
reviewed
Oct 15, 2018
plugins/shared/structs/attribute.go
Outdated
| } | ||
|
|
||
| // comparitor returns the comparitor function for the attribute | ||
| func (a *Attribute) comparitor() compareFn { |
There was a problem hiding this comment.
typo - comparator, here and in the various functions below
preetapan
reviewed
Oct 15, 2018
| "100.25mW", | ||
| } | ||
|
|
||
| // run the Fib function b.N times |
preetapan
reviewed
Oct 15, 2018
| // lengthSortedUnits is a list of unit names sorted by length with longest | ||
| // first | ||
| lengthSortedUnits = make([]string, 0, numUnits) | ||
|
|
There was a problem hiding this comment.
I didn;t check the conversion values below too closely, since there's no unit test and we are setting up the units here its worth a second look
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of fingerprinters emitting an opaque string, they can now emit a type attribute value. These attributes support a set of units as well. The attributes also support comparison, making the following possible:
10.5GiB < 12GB