Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Reset page query param on search #4822

Merged
merged 4 commits into from
Nov 1, 2018
Merged

UI: Reset page query param on search #4822

merged 4 commits into from
Nov 1, 2018

Commits on Oct 30, 2018

  1. Add onChange hook to the search-box component

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 30, 2018
    Configuration menu
    Copy the full SHA
    badb6c4 View commit details
    Browse the repository at this point in the history

  2. Add a resetPagination method to the searchable mixin 

    Searchable can be used without pagination, but reseting pagination
is more a function of search than pagination insofar as if you
add search to a page, you are also going to want automatic pagination
resetting.
    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 30, 2018
    Configuration menu
    Copy the full SHA
    f7ad2ce View commit details
    Browse the repository at this point in the history

  3. Add the resetPagination hook to search boxes across the app

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 30, 2018
    Configuration menu
    Copy the full SHA
    44e33d0 View commit details
    Browse the repository at this point in the history

  4. Test coverage for resetPagination

    @DingoEatingFuzz
    DingoEatingFuzz committed Oct 30, 2018
    Configuration menu
    Copy the full SHA
    b00916a View commit details
    Browse the repository at this point in the history