Remove terminal allocations associated with older job modify index #4839
Conversation
nomad/core_sched.go
Outdated
| func olderVersionTerminalAllocs(allocs []*structs.Allocation, job *structs.Job) []string { | ||
| var ret []string | ||
| for _, alloc := range allocs { | ||
| if alloc.Job != nil && alloc.Job.JobModifyIndex < job.JobModifyIndex && alloc.TerminalStatus() { |
There was a problem hiding this comment.
I think what you really want to test is the JobCreateIndex. I could change the priority of a job and that would change the job modify index. That doesn't mean we should GC its allocations. They are still potentially useful for scheduling decisions.
|
@preetapan we just test this patch by backport it to 0.8.6 on test stand and found that if situations described here #4532, it doesn't works, due |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR changes batch job GC behavior such that terminal allocations that have the same job id, but associated with an older job modify index get garbage collected.
This handles the case where a batch job is stopped and purged, and then resubmitted with the same id. In Nomad 0.8.6, any terminal allocations of the job at the older job modify index dont' get garbage collected until the resubmitted job is also eligible for gc.