Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple bugs with progress deadline handling #4842

Merged
merged 3 commits into from
Nov 8, 2018

Commits on Nov 6, 2018

  1. Fix multiple tgs with progress deadline handling

    Fix an issue in which the deployment watcher would fail the deployment
    based on the earliest progress deadline of the deployment regardless of
    if the task group has finished.
    
    Further fix an issue where the blocked eval optimization would make it
    so no evals were created to progress the deployment. To reproduce this
    issue, prior to this commit, you can create a job with two task groups.
    The first group has count 1 and resources such that it can not be
    placed. The second group has count 3, max_parallel=1, and can be placed.
    Run this first and then update the second group to do a deployment. It
    will place the first of three, but never progress since there exists a
    blocked eval. However, that doesn't capture the fact that there are two
    groups being deployed.
    dadgar committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    8615b1d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ccb7440 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2018

  1. review fixes

    dadgar committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    ad15649 View commit details
    Browse the repository at this point in the history