-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker driver plugin #4844
Docker driver plugin #4844
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactoring globals into the driver struct isn't a blocker.
So much code! Well done!
6cb6c8c
to
fab76c6
Compare
…entTicks field for docker driver
Co-Authored-By: nickethier <ncethier@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this merged ASAP and fixup the eventer/TaskEvents situation in a followup PR. Depending on the implementation we choose this code may be correct as-is.
Co-Authored-By: nickethier <ncethier@gmail.com>
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Docker driver and tests ported to new driver plugin framework