Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker driver plugin #4844

Merged
merged 25 commits into from
Nov 21, 2018
Merged

Docker driver plugin #4844

merged 25 commits into from
Nov 21, 2018

Conversation

nickethier
Copy link
Member

@nickethier nickethier commented Nov 6, 2018 •
edited

Docker driver and tests ported to new driver plugin framework

@schmichael schmichael changed the title WIP: docker driver plugin Docker driver plugin Nov 12, 2018
dadgar
dadgar requested changes Nov 12, 2018
View reviewed changes
client/allocrunner/taskrunner/task_runner.go Outdated Show resolved Hide resolved
plugins/drivers/driver.go Outdated Show resolved Hide resolved
plugins/drivers/proto/driver.proto Outdated Show resolved Hide resolved
drivers/docker/driver.go Show resolved Hide resolved
drivers/docker/driver.go Outdated Show resolved Hide resolved
drivers/docker/driver.go Show resolved Hide resolved
drivers/docker/driver.go Outdated Show resolved Hide resolved
drivers/docker/driver.go Show resolved Hide resolved
drivers/docker/handle.go Outdated Show resolved Hide resolved
drivers/docker/handle.go Outdated Show resolved Hide resolved
schmichael
schmichael requested changes Nov 13, 2018
View reviewed changes
Copy link
Member

@schmichael schmichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactoring globals into the driver struct isn't a blocker.

So much code! Well done!

command/commands.go Show resolved Hide resolved
drivers/docker/coordinator.go Outdated Show resolved Hide resolved
drivers/docker/coordinator.go Outdated Show resolved Hide resolved
drivers/docker/coordinator.go Show resolved Hide resolved
drivers/docker/docklog/plugin.go Outdated Show resolved Hide resolved
drivers/docker/driver.go Outdated Show resolved Hide resolved
drivers/docker/coordinator.go Outdated Show resolved Hide resolved
drivers/docker/driver.go Outdated Show resolved Hide resolved
plugins/drivers/driver.go Outdated Show resolved Hide resolved
plugins/drivers/server.go Outdated Show resolved Hide resolved
@preetapan preetapan mentioned this pull request Nov 14, 2018
Closed
@nickethier nickethier force-pushed the f-docker-plugin branch 2 times, most recently from 6cb6c8c to fab76c6 Compare November 20, 2018 03:57
nickethier and others added 21 commits November 19, 2018 22:59
@nickethier
docker: properly launch docker logger process
9d8d3e1
@nickethier
docker: started work on porting docker driver to new plugin framework
98b295d
@nickethier
drivers: support recoverable errors in the plugin RPC layer
c2d94dc
@nickethier
drivers/docker: more work porting tests from old driver plugin
5c777a3
@nickethier
drivers: added NodeResources to drivers.TaskConfig
9c154d7
@nickethier
docker: finished porting tests
902eb94
@nickethier
docker: implement recover task logic
396f6ab
@nickethier
docker: move recoverable error proto to shared structs
37ed755
@nickethier
plugins/driver: remove NodeResources from task Resources and use Perc…
3601e42 
…entTicks field for docker driver
@nickethier
docker: moved fingerprint code to it's own file
0c62b9a
@nickethier
task_runner: emit event on task exit with exit result details
cf69895
@nickethier
docker: remove call to global metrics instance
7d09ae5
@nickethier
docker: remove global pull coordinator
3468880
@schmichael @nickethier
Apply suggestions from code review
455e754 
Co-Authored-By: nickethier <ncethier@gmail.com>
@nickethier
docker: group common config into blocks
577d4a2
@nickethier
docker: move volume driver options to seperate block
d7631e3
@nickethier
docker: remove container pointer from task handle
0462c8a
@nickethier
docker: fix tests
8ae8932
@nickethier
docker: move config RPCs to config.go
249dbff
@nickethier
docker: add default blocks for driver plugin config schema
fab76c6
@nickethier
docker: unexport new coordinator func
2393f6a
@notnoop notnoop mentioned this pull request Nov 20, 2018
Merged
schmichael
schmichael approved these changes Nov 21, 2018
View reviewed changes
Copy link
Member

@schmichael schmichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this merged ASAP and fixup the eventer/TaskEvents situation in a followup PR. Depending on the implementation we choose this code may be correct as-is.

@nickethier nickethier merged commit 6667411 into master Nov 21, 2018
@nickethier nickethier deleted the f-docker-plugin branch December 5, 2018 19:20
@joebeeson joebeeson mentioned this pull request Apr 29, 2020
Closed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dadgar dadgar dadgar requested changes

@schmichael schmichael schmichael approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nickethier @schmichael @dadgar