Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract LXC from nomad #5162

Merged
merged 9 commits into from
Jan 9, 2019
Merged

Extract LXC from nomad #5162

merged 9 commits into from
Jan 9, 2019

Commits on Jan 8, 2019

  1. remove always false parameter 

    Simplify allocDir.Build() function to avoid depending on client/structs,
and remove a parameter that's always set to `false`.

The motivation here is to avoid a dependency cycle between
drivers/cstructs and alloc_dir.
    @notnoop
    Mahmood Ali authored and notnoop committed Jan 8, 2019
    Configuration menu
    Copy the full SHA
    607e7f2 View commit details
    Browse the repository at this point in the history

  2. remove deprecated allocrunner

    @notnoop
    Mahmood Ali authored and notnoop committed Jan 8, 2019
    Configuration menu
    Copy the full SHA
    2831088 View commit details
    Browse the repository at this point in the history

  3. use drivers.FSIsolation

    @notnoop
    Mahmood Ali authored and notnoop committed Jan 8, 2019
    Configuration menu
    Copy the full SHA
    694e301 View commit details
    Browse the repository at this point in the history

  4. move cstructs.DeviceNetwork to drivers pkg

    @notnoop
    Mahmood Ali authored and notnoop committed Jan 8, 2019
    Configuration menu
    Copy the full SHA
    c0162fa View commit details
    Browse the repository at this point in the history

  5. drivers: re-export ResourceUsage structs 

    Re-export the ResourceUsage structs in drivers package to avoid drivers
directly depending on the internal client/structs package directly.

I attempted moving the structs to drivers, but that caused some import
cycles that was a bit hard to disentagle.  Alternatively, I added an
alias here that's sufficient for our purposes of avoiding external
drivers depend on internal packages, while allowing us to restructure
packages in future without breaking source compatibility.
    @notnoop
    Mahmood Ali authored and notnoop committed Jan 8, 2019
    Configuration menu
    Copy the full SHA
    800a352 View commit details
    Browse the repository at this point in the history

  6. Remove some dead code

    @notnoop
    Mahmood Ali authored and notnoop committed Jan 8, 2019
    Configuration menu
    Copy the full SHA
    34ee0ba View commit details
    Browse the repository at this point in the history

  7. remove lxc references

    @notnoop
    notnoop committed Jan 8, 2019
    Configuration menu
    Copy the full SHA
    b51ecac View commit details
    Browse the repository at this point in the history

  8. remove unused go-lxc vendored library

    @notnoop
    notnoop committed Jan 8, 2019
    Configuration menu
    Copy the full SHA
    01fd085 View commit details
    Browse the repository at this point in the history

  9. appease linter

    @notnoop
    notnoop committed Jan 8, 2019
    Configuration menu
    Copy the full SHA
    d19245f View commit details
    Browse the repository at this point in the history