-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract LXC from nomad #5162
Merged
Merged
Extract LXC from nomad #5162
Commits on Jan 8, 2019
-
Simplify allocDir.Build() function to avoid depending on client/structs, and remove a parameter that's always set to `false`. The motivation here is to avoid a dependency cycle between drivers/cstructs and alloc_dir.
Configuration menu - View commit details
-
Copy full SHA for 607e7f2 - Browse repository at this point
Copy the full SHA 607e7f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2831088 - Browse repository at this point
Copy the full SHA 2831088View commit details -
Configuration menu - View commit details
-
Copy full SHA for 694e301 - Browse repository at this point
Copy the full SHA 694e301View commit details -
Configuration menu - View commit details
-
Copy full SHA for c0162fa - Browse repository at this point
Copy the full SHA c0162faView commit details -
drivers: re-export ResourceUsage structs
Re-export the ResourceUsage structs in drivers package to avoid drivers directly depending on the internal client/structs package directly. I attempted moving the structs to drivers, but that caused some import cycles that was a bit hard to disentagle. Alternatively, I added an alias here that's sufficient for our purposes of avoiding external drivers depend on internal packages, while allowing us to restructure packages in future without breaking source compatibility.
Configuration menu - View commit details
-
Copy full SHA for 800a352 - Browse repository at this point
Copy the full SHA 800a352View commit details -
Configuration menu - View commit details
-
Copy full SHA for 34ee0ba - Browse repository at this point
Copy the full SHA 34ee0baView commit details -
Configuration menu - View commit details
-
Copy full SHA for b51ecac - Browse repository at this point
Copy the full SHA b51ecacView commit details -
Configuration menu - View commit details
-
Copy full SHA for 01fd085 - Browse repository at this point
Copy the full SHA 01fd085View commit details -
Configuration menu - View commit details
-
Copy full SHA for d19245f - Browse repository at this point
Copy the full SHA d19245fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.