Reconcile child summaries correctly #5205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes incorrect parent job summaries by recomputing them in the ReconcileJobSummaries method in the state store
also added unit tests
dadgar
approved these changes
Jan 18, 2019
dev/cluster/client1.hcl
Outdated
| @@ -10,7 +10,9 @@ name = "client1" | |||
| # Enable the client | |||
| client { | |||
| enabled = true | |||
|
|
|||
| options = { | |||
nomad/state/state_store.go
Outdated
|
|
||
| // The following block of code fixes incorrect child summaries due to a bug | ||
| // See https://github.com/hashicorp/nomad/issues/3886 for details | ||
| summaryIter, err := txn.Get("job_summary", "id", job.Namespace, job.ID) |
nomad/state/state_store.go
Outdated
| } | ||
|
|
||
| rawSummary := summaryIter.Next() | ||
| if rawSummary != nil { |
There was a problem hiding this comment.
if rawSummary == nil { continue}
|
|
|
Great work @preetapan! |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a long standing bug that affects parameterized/periodic jobs when reconciling job summaries.
The
Childrenfield was being overridden to empty, and theSummaryfield values were incorrect, prior to this fix. After this fix, a leader election or using the reconcile summaries endpoint should fix the summaries to be accurate.Fixes #3886