Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression by restarting on artifact download errors #5322

Merged
merged 3 commits into from
Feb 21, 2019
Merged

Fix regression by restarting on artifact download errors #5322

merged 3 commits into from
Feb 21, 2019

Commits on Feb 20, 2019

  1. tests: add new task runner test helper 

    Adds a new helper and removes a duplicated test.
    @schmichael
    schmichael committed Feb 20, 2019
    Configuration menu
    Copy the full SHA
    8397925 View commit details
    Browse the repository at this point in the history

  2. client: artifact errors are retry-able 

    0.9.0beta2 contains a regression where artifact download errors would
not cause a task restart and instead immediately fail the task.

This restores the pre-0.9 behavior of retrying all artifact errors and
adds missing tests.
    @schmichael
    schmichael committed Feb 20, 2019
    Configuration menu
    Copy the full SHA
    c51a54c View commit details
    Browse the repository at this point in the history

  3. client: don't redownload completed artifacts on retries 

    Track the download status of each artifact independently so that if only
one of many artifacts fails to download, completed artifacts aren't
downloaded again.
    @schmichael
    schmichael committed Feb 20, 2019
    Configuration menu
    Copy the full SHA
    1acd4ca View commit details
    Browse the repository at this point in the history