-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker: report unhealthy in unsupported Windows #5356
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm aside from attr name
a4df846
to
990ac06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to unit test the fingerprint method?
On Windows, Nomad only supports Windows containers, so report as unhealthy otherwise.
990ac06
to
3d281c1
Compare
Co-Authored-By: notnoop <mahmood@notnoop.com>
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
On Windows, Nomad only supports Windows containers, so report as
unhealthy otherwise.