Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alloc-lifecycle: nomad alloc restart #5502

Merged
merged 1 commit into from
Apr 11, 2019
Merged

alloc-lifecycle: nomad alloc restart #5502

merged 1 commit into from
Apr 11, 2019

Conversation

endocrimes
Copy link
Contributor

This adds a nomad alloc restart command and api that allows a job operator with the alloc-lifecycle acl to perform an in-place restart of a Nomad allocation, or a given subtask.

It depends on #5500.

@endocrimes endocrimes marked this pull request as ready for review April 3, 2019 10:39
schmichael
schmichael approved these changes Apr 10, 2019
View reviewed changes
Copy link
Member

@schmichael schmichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just minor comments.

api/allocations.go Outdated Show resolved Hide resolved
client/allocrunner/alloc_runner.go Show resolved Hide resolved
command/agent/alloc_endpoint_test.go Show resolved Hide resolved
command/alloc_restart.go Outdated Show resolved Hide resolved
nomad/client_alloc_endpoint.go Outdated Show resolved Hide resolved
nomad/client_alloc_endpoint_test.go Show resolved Hide resolved
@endocrimes endocrimes force-pushed the dani/f-alloc-restart branch 2 times, most recently from 344c760 to 016f268 Compare April 11, 2019 12:03
@endocrimes
allocs: Add nomad alloc restart
419d70c 
This adds a `nomad alloc restart` command and api that allows a job operator
with the alloc-lifecycle acl to perform an in-place restart of a Nomad
allocation, or a given subtask.
@endocrimes endocrimes merged commit 6b60068 into master Apr 11, 2019
@endocrimes endocrimes deleted the dani/f-alloc-restart branch April 11, 2019 12:26
@endocrimes endocrimes mentioned this pull request May 9, 2019
Closed
@bhope bhope mentioned this pull request May 21, 2019
Closed
@camerondavison camerondavison mentioned this pull request Jun 6, 2019
Closed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmichael schmichael schmichael approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@endocrimes @schmichael