alloc-lifecycle: nomad alloc stop #5512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endocrimes
force-pushed
the
dani/f-alloc-stop
branch
from
35a2c90
to
440e2d4
Compare
endocrimes
force-pushed
the
dani/f-alloc-stop
branch
2 times, most recently
from
ff2dfab
to
37ebb36
Compare
nickethier
approved these changes
Apr 19, 2019
| // invoked on the alloc id | ||
| tokens := strings.Split(reqSuffix, "/") | ||
| if len(tokens) > 2 || len(tokens) < 1 { | ||
| return nil, CodedError(404, resourceNotFoundErr) |
There was a problem hiding this comment.
Questionable - Invalid routes usually result in a 404 by convention, BadRequest is usually for things that are badly formed. It's possible to use for invalid routing, but would be weird in Nomad bc we 404 everywhere else.
This adds a `nomad alloc stop` command that can be used to stop and force migrate an allocation to a different node. This is built on top of the AllocUpdateDesiredTransitionRequest and explicitly limits the scope of access to that transition to expose it under the alloc-lifecycle ACL. The API returns the follow up eval that can be used as part of monitoring in the CLI or parsed and used in an external tool.
endocrimes
force-pushed
the
dani/f-alloc-stop
branch
from
37ebb36
to
bb142af
Compare
endocrimes
added a commit
that referenced
this pull request
Apr 23, 2019
Closed
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This command will be used to signal a specific alloc to shut down. When the allocation has been shut down, it will then be rescheduled. By default, this command will then enter an interactive monitoring mode to watch for the replacement allocation and to monitor the restart period. This will then allow an operator to continue inspecting the new job, without polling
nomad statusby hand.It depends on #5500.