Allow passing -verbose to meta status #5516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endocrimes
force-pushed
the
dani/f-verbose-status
branch
from
1ad1bb1
to
89f6054
Compare
endocrimes
changed the title
cgbaker
approved these changes
Apr 10, 2019
A common issue when using nomad is needing to add in the object verb to a command to include the `-verbose` flag. This commit allows users to pass `-verbose` via the `nomad status` alias by adding a placeholder boolean in the metacommand which allows subcommands to parse the flag.
endocrimes
force-pushed
the
dani/f-verbose-status
branch
from
89f6054
to
38e73b5
Compare
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A common issue when using nomad is needing to add in the object verb to
a command to include the
-verboseflag.This commit allows users to pass
-verbosevia thenomad statusalias byadding a placeholder boolean in the metacommand which allows subcommands
to parse the flag.
If anyone has suggestions as to alternative ways to allow this to be delegated (rather than parsing into an unused bool) then I'm happy to hear them, but I couldn't see any other obvious way.