Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add telemetry overview section #5529

Merged
merged 15 commits into from
Jun 19, 2019
Merged

[WIP] Add telemetry overview section #5529

merged 15 commits into from
Jun 19, 2019

Conversation

Omar-Khawaja
Copy link
Contributor

@Omar-Khawaja Omar-Khawaja commented Apr 8, 2019

In the process of taking some monitoring and alerting info and adding it into an Overview section of the telemetry docs.

Still updating some of the information from the document. WIP

@Omar-Khawaja
Copy link
Contributor Author

Omar-Khawaja commented Apr 9, 2019

@rcgenova @yishan-lin can you take a look at this and provide some feedback on the structure? I took some monitoring and alerting info and put it under Overview in the telemetry docs as the first bullet in the navigation. The second bullet has the documentation that already existed with an added Tagged Metrics section.

Copy link
Contributor

@yishan-lin yishan-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@cgbaker cgbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. general typesetting changes.

website/source/docs/telemetry/overview.html.md Outdated Show resolved Hide resolved
website/source/docs/telemetry/overview.html.md Outdated Show resolved Hide resolved
website/source/docs/telemetry/overview.html.md Outdated Show resolved Hide resolved
website/source/docs/telemetry/overview.html.md Outdated Show resolved Hide resolved
website/source/docs/telemetry/overview.html.md Outdated Show resolved Hide resolved
website/source/docs/telemetry/metrics.html.md Outdated Show resolved Hide resolved
website/source/docs/telemetry/metrics.html.md Outdated Show resolved Hide resolved
website/source/docs/telemetry/metrics.html.md Show resolved Hide resolved
website/source/docs/telemetry/metrics.html.md Show resolved Hide resolved
@Omar-Khawaja Omar-Khawaja merged commit 6d889fe into master Jun 19, 2019
@Omar-Khawaja Omar-Khawaja deleted the telemetry-overview branch June 19, 2019 19:25
Omar-Khawaja added a commit that referenced this pull request Jun 19, 2019
* re-arrange telemetry docs and add overview with navigation

* update job and task status section

* fix navigation

* Update website/source/docs/telemetry/overview.html.md

Co-Authored-By: Chris Baker <cgbaker@hashicorp.com>

* Update website/source/docs/telemetry/overview.html.md

Co-Authored-By: Chris Baker <cgbaker@hashicorp.com>

* Update website/source/docs/telemetry/overview.html.md

Co-Authored-By: Chris Baker <cgbaker@hashicorp.com>

* Update website/source/docs/telemetry/metrics.html.md

Co-Authored-By: Chris Baker <cgbaker@hashicorp.com>

* Update website/source/docs/telemetry/metrics.html.md

Co-Authored-By: Chris Baker <cgbaker@hashicorp.com>

* fix formatting for nomad.plan.evaluate metric

* clarifications on collection interval and namespace labell

* fix typo

* Update website/source/docs/telemetry/overview.html.md

Co-Authored-By: Chris Baker <cgbaker@hashicorp.com>

* Update website/source/docs/telemetry/overview.html.md

Co-Authored-By: Chris Baker <cgbaker@hashicorp.com>

* Update website/source/docs/telemetry/overview.html.md

Co-Authored-By: Chris Baker <cgbaker@hashicorp.com>
Omar-Khawaja added a commit that referenced this pull request Jun 19, 2019
* re-arrange telemetry docs and add overview with navigation

* update job and task status section

* fix navigation

* Update website/source/docs/telemetry/overview.html.md

Co-Authored-By: Chris Baker <cgbaker@hashicorp.com>

* Update website/source/docs/telemetry/overview.html.md

Co-Authored-By: Chris Baker <cgbaker@hashicorp.com>

* Update website/source/docs/telemetry/overview.html.md

Co-Authored-By: Chris Baker <cgbaker@hashicorp.com>

* Update website/source/docs/telemetry/metrics.html.md

Co-Authored-By: Chris Baker <cgbaker@hashicorp.com>

* Update website/source/docs/telemetry/metrics.html.md

Co-Authored-By: Chris Baker <cgbaker@hashicorp.com>

* fix formatting for nomad.plan.evaluate metric

* clarifications on collection interval and namespace labell

* fix typo

* Update website/source/docs/telemetry/overview.html.md

Co-Authored-By: Chris Baker <cgbaker@hashicorp.com>

* Update website/source/docs/telemetry/overview.html.md

Co-Authored-By: Chris Baker <cgbaker@hashicorp.com>

* Update website/source/docs/telemetry/overview.html.md

Co-Authored-By: Chris Baker <cgbaker@hashicorp.com>
@github-actions
Copy link

github-actions bot commented Feb 8, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants