client/metrics: fixed bad metrics #5541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmichael
approved these changes
Apr 16, 2019
cgbaker
force-pushed
the
b/5540-bad-client-alloc-metrics
branch
2 times, most recently
from
c8b3761
to
d0021cd
Compare
…cation instead of (unupdated) server copy
cgbaker
force-pushed
the
b/5540-bad-client-alloc-metrics
branch
from
d0021cd
to
7d8fa4c
Compare
|
test to follow in another PR after dealing with some changes in go-metrics library |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5540: modified metrics calculation to use (updated) client copy of the allocation instead of (un-updated) server copy