client fingerprinter doesn't overwrite manual configuration #5553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
langmartin
force-pushed
the
b-fingerprinter-manual-config
branch
from
c1798e8
to
f5c6219
Compare
notnoop
approved these changes
Apr 23, 2019
nomad/structs/structs_test.go
Outdated
| } | ||
| if !ns.Equals(&Networks{ | ||
| &NetworkResource{Device: "eth0"}, | ||
| }) { |
There was a problem hiding this comment.
I would encourage use of testify as it has nicer output than plain t.Fatal() that makes it easier to find failing conditions in a stream of logs and test output.
This would be something like:
require.True(t, ns.Equals(&Networks{&NetworkResource{Device: "eth0"}}))
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert "Revert accidental merge of pr #5482"
This reverts commit c45652a.
This revert revert reinstates the changes from the pull request, now based on the master branch