Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nomad exec part 3: executor based drivers #5634

Merged
merged 5 commits into from
May 11, 2019
Merged

nomad exec part 3: executor based drivers #5634

merged 5 commits into from
May 11, 2019

Commits on May 10, 2019

  1. executor: scaffolding for executor grpc handling 

    Prepare executor to handle streaming exec API calls that reuse drivers protobuf
structs.
    Mahmood Ali committed May 10, 2019
    Configuration menu
    Copy the full SHA
    efc4249 View commit details
    Browse the repository at this point in the history

  2. executors: implement streaming exec 

    Implements streamign exec handling in both executors (i.e. universal and
libcontainer).

For creation of TTY, some incidental complexity leaked in.  The universal
executor uses github.com/kr/pty for creation of TTYs.

On the other hand, libcontainer expects a console socket and for libcontainer to
create the underlying console object on process start.  The caller can then use
`libcontainer.utils.RecvFd()` to get tty master end.

I chose github.com/kr/pty for managing TTYs here.  I tried
`github.com/containerd/console` package (which is already imported), but the
package did not work as expected on macOS.
    Mahmood Ali committed May 10, 2019
    Configuration menu
    Copy the full SHA
    976bfbc View commit details
    Browse the repository at this point in the history

  3. drivers: implement streaming exec for executor based drivers 

    These simply delegate call to backend executor.
    Mahmood Ali committed May 10, 2019
    Configuration menu
    Copy the full SHA
    74e5e20 View commit details
    Browse the repository at this point in the history

  4. vendor github.com/kr/pty

    Mahmood Ali committed May 10, 2019
    Configuration menu
    Copy the full SHA
    f6a4b88 View commit details
    Browse the repository at this point in the history

  5. use pty/tty terminology similar to github.com/kr/pty

    Mahmood Ali committed May 10, 2019
    Configuration menu
    Copy the full SHA
    7f76aed View commit details
    Browse the repository at this point in the history