Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary locking and serverlist syncing in heartbeats #5654

Merged
merged 3 commits into from
May 8, 2019
Merged

Remove unnecessary locking and serverlist syncing in heartbeats #5654

merged 3 commits into from
May 8, 2019

Commits on May 6, 2019

  1. Remove unnecessary locking and serverlist syncing in heartbeats 

    This removes an unnecessary shared lock between discovery and heartbeating
which was causing heartbeats to be missed upon retries when a single server
fails. Also made a drive by fix to call the periodic server shuffler goroutine.
    @preetapan
    preetapan committed May 6, 2019
    Configuration menu
    Copy the full SHA
    5f88d0f View commit details
    Browse the repository at this point in the history

Commits on May 7, 2019

  1. code review feedback

    @preetapan
    preetapan committed May 7, 2019
    Configuration menu
    Copy the full SHA
    12e1804 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2019

  1. fix typo and add one more test scenario

    @preetapan
    preetapan committed May 8, 2019
    Configuration menu
    Copy the full SHA
    5bfa35a View commit details
    Browse the repository at this point in the history