Sort output of agent-info

[zytek]

Sorting output of agent-info makes it much more user-friendly.

Note: I'm not a Go developer so feel free to refactor it or leave a comment how to improve it. This is just a proposition.

[cbednarski]

You can simplify this as stats_keys := make([]string, len(stats))

[c4milo]

Keep in mind that stats_keys is not a idiomatic variable notation in Go. It should be statsKeys (camelcase). My 2 cents.

[zytek]

Thank you for the comments, I've cleaned up variable names.

One thing got me curious, changing this:

-       statsKeys := make([]string, 0, len(stats))
+       statsKeys := make([]string, len(stats))
-               statsDataKeys := make([]string, 0, len(statsData))
+               statsDataKeys := make([]string, len(statsData))

Made agent-info return a bunch of empy = nil outputs as per this example

serf
   = <nil>
   = <nil>
   = <nil>
   = <nil>
   = <nil>
   = <nil>
   = <nil>
   = <nil>
   = <nil>
   = <nil>
  encrypted = false
  event_queue = 0
  event_time = 1
  failed = 0
  intent_queue = 0
  left = 0
  member_time = 1
  members = 1
  query_queue = 0

Can you explain that? Is it because im re-using variables or what?

[dadgar]

Closing in favor of #617.
@zytek you can see the fix in my commit. You were creating the slice at the desired size and then appending to it, instead of writing the keys in the created indexes.

[zytek]

Thx @dadgar !

BTW, judging by hashicorp/consul#969 - I guess both implementations are fine and it's just a matter of style ;-)

[github-actions]

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.