Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nomad: revert use of SnapshotAfter in planApply #5773

Merged
merged 1 commit into from
Jun 4, 2019

Commits on Jun 3, 2019

  1. nomad: revert use of SnapshotAfter in planApply

    Revert plan_apply.go changes from #5411
    
    Since non-Command Raft messages do not update the StateStore index,
    SnapshotAfter may unnecessarily block and needlessly fail in idle
    clusters where the last Raft message is a non-Command message.
    
    This is trivially reproducible with the dev agent and a job that has 2
    tasks, 1 of which fails.
    
    The correct logic would be to SnapshotAfter the previous plan's index to
    ensure consistency. New clusters or newly elected leaders will not have
    a previous plan, so the index the leader was elected should be used
    instead.
    schmichael committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    cd3cd0a View commit details
    Browse the repository at this point in the history