Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a panic related to updating alloc taskgroups #5805

Merged
merged 3 commits into from
Jun 11, 2019
Merged

Fix a panic related to updating alloc taskgroups #5805

merged 3 commits into from
Jun 11, 2019

Commits on Jun 10, 2019

  1. test that stopped alloc jobs aren't modified 

    When an alloc is stopped, test that we don't update the job found in
alloc with new job  that is no longer relevent for this alloc.
    Mahmood Ali committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    8ccb6bf View commit details
    Browse the repository at this point in the history

  2. Stop updating allocs.Job on stopping or preemption

    Mahmood Ali committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    7825a3c View commit details
    Browse the repository at this point in the history

  3. client/allocrunner: depend on internal task state 

    Alloc runner already tracks tasks associated with alloc.  Here, we
become defensive by relying on the alloc runner tracked tasks, rather
than depend on server never updating the job unexpectedly.
    Mahmood Ali committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    41a7fe8 View commit details
    Browse the repository at this point in the history