Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trhooks: Add TaskStopHook interface to services #5821

Merged
merged 2 commits into from
Jun 12, 2019
Merged

trhooks: Add TaskStopHook interface to services #5821

merged 2 commits into from
Jun 12, 2019

Commits on Jun 12, 2019

  1. trhooks: Add TaskStopHook interface to services 

    We currently only run cleanup Service Hooks when a task is either
Killed, or Exited. However, due to the implementation of a task runner,
tasks are only Exited if they every correctly started running, which is
not true when you recieve an error early in the task start flow, such as
not being able to pull secrets from Vault.

This updates the service hook to also call consul deregistration
routines during a task Stop lifecycle event, to ensure that any
registered checks and services are cleared in such cases.

fixes #5770
    @endocrimes
    endocrimes committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    5933528 View commit details
    Browse the repository at this point in the history

  2. trt: Fix test

    @endocrimes
    endocrimes committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    1aa6bc8 View commit details
    Browse the repository at this point in the history