Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid de-registering slowly restored services #5837

Merged
merged 2 commits into from
Jul 17, 2019
Merged

Commits on Jun 14, 2019

  1. Avoid de-registering slowly restored services

    When a nomad client restarts/upgraded, nomad restores state from running
    task and starts the sync loop.  If sync loop runs early, it may
    deregister services from Consul prematurely even when Consul has the
    running service as healthy.
    
    This is not ideal, as re-registering the service means potentially
    waiting a whole service health check interval before declaring the
    service healthy.
    
    We attempt to mitigate this by introducing an initialization probation
    period.  During this time, we only deregister services and checks that
    were explicitly deregistered, and leave unrecognized ones alone.  This
    serves as a grace period for restoring to complete, or for operators to
    restore should they recognize they restored with the wrong nomad data
    directory.
    Mahmood Ali committed Jun 14, 2019
    Configuration menu
    Copy the full SHA
    90d488b View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2019

  1. address review feedback

    Mahmood Ali committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    121c974 View commit details
    Browse the repository at this point in the history