Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Add allocation directory rendering #5873

Merged
merged 104 commits into from
Jul 2, 2019

Commits on Jun 21, 2019

  1. Configuration menu
    Copy the full SHA
    6f984ac View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    274d1d6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2796b07 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5f0e0a9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    875e09c View commit details
    Browse the repository at this point in the history
  6. Convert list to table

    backspace committed Jun 21, 2019
    Configuration menu
    Copy the full SHA
    1d0c200 View commit details
    Browse the repository at this point in the history
  7. Add entry sizes

    backspace committed Jun 21, 2019
    Configuration menu
    Copy the full SHA
    6025ede View commit details
    Browse the repository at this point in the history
  8. Add tbody

    backspace committed Jun 21, 2019
    Configuration menu
    Copy the full SHA
    ca2baf3 View commit details
    Browse the repository at this point in the history
  9. Add file mode to table

    backspace committed Jun 21, 2019
    Configuration menu
    Copy the full SHA
    b8a5c42 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    75edb48 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    30e6771 View commit details
    Browse the repository at this point in the history
  12. Add scenario for stable preview demonstration

    This doesn’t work in every instance; sometimes when I refresh
    there’s a failure. I’ll have to tune the models created to
    eliminate these occasional problems.
    backspace committed Jun 21, 2019
    Configuration menu
    Copy the full SHA
    3726a6d View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2019

  1. Add empty commit

    backspace committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    71c8c82 View commit details
    Browse the repository at this point in the history
  2. Add last modified column

    backspace committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    ad5621b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    976cff0 View commit details
    Browse the repository at this point in the history
  4. Remove file icon

    backspace committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    8eefd43 View commit details
    Browse the repository at this point in the history
  5. Add navigation into directories

    This will surely break under some circumstances; refinement
    to come.
    backspace committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    f1a4729 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    65635bc View commit details
    Browse the repository at this point in the history
  7. Add preliminary styling

    backspace committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    0856bb0 View commit details
    Browse the repository at this point in the history
  8. Remove file mode column

    backspace committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    df5b49e View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    abf4f94 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    acfed97 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    3eadd6d View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    4dae829 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    2a41ca6 View commit details
    Browse the repository at this point in the history
  14. Add assertions on complete breadcrumbs text

    This isn’t truly necessary but I think it makes it easier
    to understand the test.
    backspace committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    095ac6a View commit details
    Browse the repository at this point in the history
  15. Fix breadcrumb paths

    backspace committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    cc36fe5 View commit details
    Browse the repository at this point in the history
  16. Fix typo

    backspace committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    d89d5b7 View commit details
    Browse the repository at this point in the history
  17. Update test name

    backspace committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    92266ee View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    04975f1 View commit details
    Browse the repository at this point in the history
  19. Restore skipped test

    backspace committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    999f57a View commit details
    Browse the repository at this point in the history
  20. Change test name

    backspace committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    02867c0 View commit details
    Browse the repository at this point in the history
  21. Add extensions to files in mock structure

    This lets the mock endpoint be more general.
    backspace committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    7a15b23 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    c59282e View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    e77f2eb View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    53213a0 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2019

  1. Rename page object property

    backspace committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    912f730 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6ca3b5a View commit details
    Browse the repository at this point in the history
  3. Remove temporary title

    backspace committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    806b9bf View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    dfba2b2 View commit details
    Browse the repository at this point in the history
  5. Update file size heading

    backspace committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    c0fc9a4 View commit details
    Browse the repository at this point in the history
  6. Add title for raw file modification datetime

    I’d normally have assertions for this but getting it out of
    the hardcoded Mirage route handler is Too Much ☹️
    backspace committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    9490c74 View commit details
    Browse the repository at this point in the history
  7. Move breadcrumbs into table

    This may not make sense with the file viewer… TBD
    backspace committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    fc7baa7 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    3d0f4e2 View commit details
    Browse the repository at this point in the history
  9. Add missing class name

    backspace committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    d12df39 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    5593ae6 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    0e8f569 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    343a093 View commit details
    Browse the repository at this point in the history
  13. Restore file icon

    backspace committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    16fcf9c View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2019

  1. Configuration menu
    Copy the full SHA
    8c28f57 View commit details
    Browse the repository at this point in the history
  2. Update Mirage scenario to work reliably

    It would periodically display an error when visiting a deep
    link into the allocation filesystem.
    backspace committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    3fafe68 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    df53346 View commit details
    Browse the repository at this point in the history
  4. Update routing so …/fs shows root directory

    This is a bit strange but I couldn’t figure out another way
    apart from extracting to a component, and it seemed like a
    shame to lose the built-in functionality of routes.
    backspace committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    8fd85b5 View commit details
    Browse the repository at this point in the history
  5. Remove placeholder title

    backspace committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    c0d1cdd View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    65ddf93 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    dab54a6 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    84a4b78 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    4e91134 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    f9a25d9 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    96200ba View commit details
    Browse the repository at this point in the history
  12. Fix indentation

    backspace committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    d34433b View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    8d390f9 View commit details
    Browse the repository at this point in the history
  14. Convert task subnav partial to component

    This will allow the component to encapsulate route-checking
    logic to show the files link as active both at root and within
    subdirectories.
    backspace committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    bdf681d View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    19313e6 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2019

  1. Add prototype loading animation

    This only applies to directory entries and not breadcrumbs,
    where it would either cause overlap or maybe weird jumping,
    but it’s more for demonstration/conversation.
    
    Thanks to @StephanWagner for the examples here:
    https://stephanwagner.me/only-css-loading-spinner
    backspace committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    3313a2e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ac94741 View commit details
    Browse the repository at this point in the history
  3. Add loading animation for breadcrumb links

    I thought I would hate the jumping when the animation appears
    but it actually seems fine!
    backspace committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    74fc0ce View commit details
    Browse the repository at this point in the history
  4. Change width of name column

    In the absence of a flex-grow-like quality for tables, this
    handles more viewport widths.
    backspace committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    0ca2353 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d7232fa View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    23623ec View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    6aae341 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    d0f6028 View commit details
    Browse the repository at this point in the history
  9. Add handling for fs/ API errors

    The API returns 500 when a file or directory is not found,
    with the “no such file or directory” in the response, so
    this converts it to a 404 based on those qualities.
    
    TBD: is the response the same across platforms?
    backspace committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    853add7 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    492e1d7 View commit details
    Browse the repository at this point in the history
  11. Rename breadcrumbs property

    backspace committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    cc93a79 View commit details
    Browse the repository at this point in the history
  12. Remove unused property

    backspace committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    4c13f15 View commit details
    Browse the repository at this point in the history
  13. Refactor breadcrumbs computed property

    This is still a bit more convoluted than I’d like, which is
    maybe the tragic outcome of using reduce… should I just make
    it a for loop? 😢
    backspace committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    da971d6 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    aa2c08d View commit details
    Browse the repository at this point in the history
  15. Remove unused dependent key

    backspace committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    4e8e2f3 View commit details
    Browse the repository at this point in the history
  16. Remove unused animation

    backspace committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    6d53d05 View commit details
    Browse the repository at this point in the history
  17. Fix comment

    backspace committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    c601a27 View commit details
    Browse the repository at this point in the history
  18. Change to double quotes

    backspace committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    d6f71f2 View commit details
    Browse the repository at this point in the history
  19. Remove FIXME re Mirage fs endpoint

    I feel like there’s no need to add any abstraction here.
    backspace committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    7c0b35c View commit details
    Browse the repository at this point in the history
  20. Change test to use hardcoded task name

    This slightly improves readability, IMO.
    backspace committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    48ce41f View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2019

  1. Correct import name

    backspace committed Jun 28, 2019
    Configuration menu
    Copy the full SHA
    07e8863 View commit details
    Browse the repository at this point in the history
  2. Rename task property in controller

    Since there’s no partial anymore, it seems more clear to
    not have a model property anymore when there are so many
    properties to work with.
    backspace committed Jun 28, 2019
    Configuration menu
    Copy the full SHA
    2215038 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4c845e8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ea6685d View commit details
    Browse the repository at this point in the history
  5. Remove unused properties

    backspace committed Jun 28, 2019
    Configuration menu
    Copy the full SHA
    94de177 View commit details
    Browse the repository at this point in the history
  6. Reduce assertion complexity

    backspace committed Jun 28, 2019
    Configuration menu
    Copy the full SHA
    95664ee View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    dbba6a2 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2019

  1. Configuration menu
    Copy the full SHA
    7793c85 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    51079cb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    506d235 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a62308d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f6421b4 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e4da8bf View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    09d88f3 View commit details
    Browse the repository at this point in the history
  8. Change to use x-icon

    backspace committed Jul 2, 2019
    Configuration menu
    Copy the full SHA
    ae93227 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    437492b View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    2d221bd View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    d18ede9 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    24c25f6 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    ea4fd68 View commit details
    Browse the repository at this point in the history