Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task runner to avoid running task if terminal #5890

Merged
merged 2 commits into from
Jul 2, 2019

Commits on Jun 27, 2019

  1. task runner to avoid running task if terminal

    This change fixes a bug where nomad would avoid running alloc tasks if
    the alloc is client terminal but the server copy on the client isn't
    marked as running.
    
    Here, we fix the case by having task runner uses the
    allocRunner.shouldRun() instead of only checking the server updated
    alloc.
    
    Here, we preserve much of the invariants such that `tr.Run()` is always
    run, and don't change the overall alloc runner and task runner
    lifecycles.
    
    Fixes #5883
    Mahmood Ali committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    f3c944a View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2019

  1. address review comments

    Mahmood Ali committed Jul 2, 2019
    Configuration menu
    Copy the full SHA
    009f186 View commit details
    Browse the repository at this point in the history