Add Mirage-toggling via environment variable #5899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I’m finding myself having to revert my change to this variable when I switch branches, so this would let me affect the variable without code changes.
DingoEatingFuzz
approved these changes
Jul 2, 2019
DingoEatingFuzz
added a commit
that referenced
this pull request
Jul 2, 2019
* origin/master: (32 commits) Added additional test cases and fixed go test case update changelog Add Mirage-toggling via environment variable (#5899) changelog: Add entries for windows fixes fifo: Safer access to Conn run post-run/post-stop task runner hooks Fail alloc if alloc runner prestart hooks fail address review comments changelog Missed one revert of backwards compatibility for node drain Improve test cases for detecting content type Undo removal of node drain compat changes Updated with suggestions. fifo: Close connections and cleanup lock handling logmon: Add windows compatibility test client: defensive against getting stale alloc updates Infer content type in alloc fs stat endpoint appveyor: Run logmon tests fifo: Require that fifos do not exist for create vendor: Use dani fork of go-winio ...
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’m finding myself having to revert my change to this
variable when I switch branches, so this would let me
affect the variable without code changes.