Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate task event struct with kill timeout #5943

Merged
merged 2 commits into from
Jul 10, 2019

Conversation

preetapan
Copy link
Contributor

This makes for a nicer task event message when the task is killed

Fixes #5931

This makes for a nicer task event message
Copy link
Contributor

@notnoop notnoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thanks!

}
expectedKillingMsg := "Sent interrupt. Waiting 10ms before force killing"

if killingMsg != expectedKillingMsg {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest moving this check after !found. Logically, we should only perform check if the kill event is found; if not found, we'd like a not found error message.

@preetapan preetapan merged commit abc747d into master Jul 10, 2019
@preetapan preetapan deleted the b-allocrunner-killtimeout branch October 17, 2019 14:10
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

when nomad alloc stop invoked in allocation status doesn't show "Waiting %v before force killing"
3 participants