Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect driver stats when driver plugins are restarted #5948

Merged
merged 3 commits into from
Jul 17, 2019

Commits on Jul 11, 2019

  1. Signal plugin shutdown for driver.TaskStats

    The driver plugin stub client must call `grpcutils.HandleGrpcErr` to handle plugin
    shutdown similar to other functions.  This ensures that TaskStats returns
    `ErrPluginShutdown` when plugin shutdown.
    Mahmood Ali committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    d8a43b2 View commit details
    Browse the repository at this point in the history
  2. client/taskrunner: fix stats stats retry logic

    Previously, if a channel is closed, we retry the Stats call.  But, if that call
    fails, we go in a backoff loop without calling Stats ever again.
    
    Here, we use a utility function for calling driverHandle.Stats call that retries
    as one expects.
    
    I aimed to preserve the logging formats but made small improvements as I saw fit.
    Mahmood Ali committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    bbf8f90 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2019

  1. log unrecoverable errors

    Mahmood Ali committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    66bef39 View commit details
    Browse the repository at this point in the history