HostVolumes: Include volume info in nomad node status

[endocrimes]

NOTE: When #5923 is merged into f-host-volumes, this PR should be targeted against f-host-volumes

Short Output

$ nomad node status -self -short
ID           = 964f7030
Name         = mew
Class        = <none>
DC           = dc1
Drain        = false
Eligibility  = eligible
Status       = ready
Host Volumes = tmp-dir
Drivers      = docker,mock_driver,raw_exec

Allocations
No allocations placed

Verbose Output

ID          = 964f7030-9882-a359-7965-2bd432fbdd96
Name        = mew
Class       = <none>
DC          = dc1
Drain       = false
Eligibility = eligible
Status      = ready
Uptime      = 168h8m18s

Host Volumes
Name     ReadOnly  Hidden  Source
tmp-dir  false     false   /tmp

Drivers
Driver       Detected  Healthy  Message                  Time
docker       true      true     Healthy                  2019-07-25T15:30:20+02:00
exec         false     false    Driver must run as root  2019-07-25T15:30:20+02:00
java         false     false    Driver must run as root  2019-07-25T15:30:20+02:00
mock_driver  true      true     Healthy                  2019-07-25T15:30:20+02:00
qemu         false     false    <none>                   2019-07-25T15:30:20+02:00
raw_exec     true      true     Healthy                  2019-07-25T15:30:20+02:00
rkt          false     false    Driver must run as root  2019-07-25T15:30:20+02:00

Node Events
Time                       Subsystem  Message          Details
2019-07-25T15:30:20+02:00  Cluster    Node registered  <none>

Allocated Resources
CPU          Memory      Disk
0/32000 MHz  0 B/15 GiB  0 B/7.5 GiB

Allocation Resource Utilization
CPU          Memory
0/32000 MHz  0 B/15 GiB

Host Resource Utilization
CPU            Memory         Disk
516/32000 MHz  11 GiB/15 GiB  (tmpfs)

Allocations
No allocations placed

Attributes
{{omitted}}

Meta

[notnoop]

Code lgtm - Had a minor code stylistic issues that aren't blockers. Would love some basic tests though for merging.

[endocrimes]

@notnoop Generally cleaned up a couple of parts of this command to make it a bit easier to understand what's going on.

• Made short be more self contained and return early, so we can not think about it for the remainder of the formatter.
• Improved comments around what we're rendering

[notnoop]

overall looks good to me. Nitpick about error messaging, but would be really nice to have some tests for this namespace.

[notnoop]

I'd return the error prefix here instead of the caller side. Had the function been queryAllocInfo, having callers add the prefix would be reasonable imo.

Suggested change

	return err
	return fmt.Errorf("failed to query node allocations: %s", err)

[notnoop]

Terminating early here is very nice; it's much more obvious what the short flag displays here imo - thanks for doing this!

[github-actions]

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.