Add page titles to filesystem routes #6024
Conversation
| if (path.startsWith('/')) { | ||
| return path; | ||
| } else { | ||
| return `/${path}`; |
There was a problem hiding this comment.
We might also want to check that it doesn't start with [A-Z]:\ too? Not sure how the FS api works on windows tho tbh
There was a problem hiding this comment.
hmm good question, thanks. Is there some cloud-y deployment of Nomad I can use? Or maybe I can set it up locally in a virtual machine 😯
There was a problem hiding this comment.
A local vm is probably your best bet right now 😞
There was a problem hiding this comment.
I finally managed it. It looks like \s are abstracted away:
I was able to query server\empty.txt and get the same response. So maybe I don’t have to care about \s 🤔
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
I wish something like Ruby’s
Pathnamewere a trivial inclusion 😐