Fix navigation via clicking recent allocation row #6087
Conversation
backspace
changed the title
| @@ -20,7 +23,7 @@ export default Component.extend({ | |||
|
|
|||
| actions: { | |||
| gotoAllocation(allocation) { | |||
| this.transitionToRoute('allocations.allocation', allocation); | |||
| this.router.transitionTo('allocations.allocation', allocation.id); | |||
There was a problem hiding this comment.
any specific reason to reload the record?
There was a problem hiding this comment.
I found that without the .id, I got this error:
You didn't provide enough string/numeric parameters to satisfy all of the dynamic segments for route
My belief is that it’s because the router is expecting allocation_id, but the model only has an id. Changing the router seemed like Too Much for this small fix.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
I noticed that the allocation row from job overview had the pointer cursor but clicking outside the allocation id didn’t actually do anything. It looks like the action was written for a controller context, so I changed it to use the router service. I also added
.idto the transition call because without it I was gettingYou didn't provide enough string/numeric parameters to satisfy all of the dynamic segments for route. Maybe this is because the router definition is looking forallocation_id, but I didn’t want to get into changing that.I added a test, which ended up being a set of tests, because of the
moduleForJobextraction. You can see it failing here (linking to a set of lines intravis-webappears to be broken 😞) before I committed the fix.