Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initialize device manager stats interval #6201

Merged
merged 1 commit into from
Aug 24, 2019
Merged

initialize device manager stats interval #6201

merged 1 commit into from
Aug 24, 2019

Commits on Aug 23, 2019

  1. initialize device manager stats interval 

    Fixes a bug where we cpu is pigged at 100% due to collecting devices
statistics.  The passed stats interval was ignored, and the default zero
value causes a very tight loop of stats collection.

FWIW, in my testing, it took 2.5-3ms to collect nvidia GPU stats, on a
`g2.2xlarge` ec2 instance.

The stats interval defaults to 1 second and is user configurable.  I
believe this is too frequent as a default, and I may advocate for
reducing it to a value closer to 5s or 10s, but keeping it as is for
now.

Fixes #6057 .
    Mahmood Ali committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    01983ae View commit details
    Browse the repository at this point in the history