upgrade go-getter, leave compiled protobuf at version 1.2 #6215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notnoop
reviewed
Aug 27, 2019
vendor/vendor.json
Outdated
| @@ -145,6 +152,7 @@ | |||
| {"path":"github.com/godbus/dbus","checksumSHA1":"bFplS7sPkJNtlKKCIszFQkAsmGI=","origin":"github.com/opencontainers/runc/vendor/github.com/godbus/dbus","revision":"459bfaec1fc6c17d8bfb12d0a0f69e7e7271ed2a","revisionTime":"2018-08-23T14:46:37Z"}, | |||
| {"path":"github.com/gogo/protobuf/proto","checksumSHA1":"I460dM/HmGE9DWimQvd1hJkYosU=","revision":"616a82ed12d78d24d4839363e8f3c5d3f20627cf","revisionTime":"2017-11-09T18:15:19Z"}, | |||
| {"path":"github.com/golang/protobuf/proto","checksumSHA1":"Pyou8mceOASSFxc7GeXZuVdSMi0=","revision":"b4deda0973fb4c70b50d226b1af49f3da59f5265","revisionTime":"2018-04-30T18:52:41Z","version":"v1","versionExact":"v1.1.0"}, | |||
| {"path":"github.com/golang/protobuf/protoc-gen-go/descriptor","checksumSHA1":"DA2cyOt1W92RTyXAqKQ4JWKGR8U=","revision":"aa810b61a9c79d51363740d207bb46cf8e620ed5","revisionTime":"2018-08-14T21:14:27Z","version":"v1.2.0","versionExact":"v1.2.0"}, | |||
There was a problem hiding this comment.
Would it make sense to pin this package to the same sha as other github.com/golang/protobuf/ packages?
| {"path":"google.golang.org/genproto/googleapis/rpc/status","checksumSHA1":"AvVpgwhxhJgjoSledwDtYrEKVE4=","revision":"b0a3dcfcd1a9bd48e63634bd8802960804cf8315","revisionTime":"2017-07-11T23:52:30Z"}, | ||
| {"path":"google.golang.org/genproto/googleapis/type/expr","checksumSHA1":"AyISVQkdxcMLS/tagl6PJFTs8Bs=","revision":"b515fa19cec88c32f305a962f34ae60068947aea","revisionTime":"2019-05-08T19:38:15Z"}, |
There was a problem hiding this comment.
Same here. Should we upgrade google.golang.org/genproto/googleapis/rpc/status to b515fa as well to be consistent.
notnoop
approved these changes
Aug 28, 2019
Closed
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades go-getter to master + hashicorp/go-getter#198. Compiled protobuf packages have not been upgraded.
go-getter's support for GCP includes a large number of dependencies.
This version of go-getter does not contain the symlink support that allowed hashicorp/go-getter#175 or any of the pending PRs to re-introduce that support.