Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs around docker start retries #6326

Merged
merged 3 commits into from
Sep 18, 2019
Merged

Fix bugs around docker start retries #6326

merged 3 commits into from
Sep 18, 2019

Commits on Sep 13, 2019

  1. docker: defensive against failed starts 

    This handles a bug where we may start a container successfully, yet we
fail due to retries and startContainer not being idempotent call.

Here, we ensure that when starting a container fails with 500 error,
the retry succeeds if container was started successfully.
    Mahmood Ali committed Sep 13, 2019
    Configuration menu
    Copy the full SHA
    2f47a6d View commit details
    Browse the repository at this point in the history

  2. retry transient docker errors within function

    Mahmood Ali committed Sep 13, 2019
    Configuration menu
    Copy the full SHA
    d505168 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2019

  1. add exponential backoff for docker api calls

    Mahmood Ali committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    b5b445c View commit details
    Browse the repository at this point in the history