Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: remove containers on creation failures #6346

Merged
merged 1 commit into from
Sep 18, 2019
Merged

docker: remove containers on creation failures #6346

merged 1 commit into from
Sep 18, 2019

Commits on Sep 18, 2019

  1. docker: remove containers on creation failures 

    The docker creation API calls may fail with http errors (e.g. timeout)
even if container was successfully created.

Here, we force remove container if we got unexpected failure.  We
already do this in some error handlers, and this commit updates all
paths.

I stopped short from a more aggressive refactoring, as the code is ripe
for refactoring and would rather do that in another PR.
    Mahmood Ali committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    8c29de2 View commit details
    Browse the repository at this point in the history