Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some connect connect validation #6575

Merged
merged 3 commits into from
Oct 28, 2019
Merged

Fix some connect connect validation #6575

merged 3 commits into from
Oct 28, 2019

Commits on Oct 28, 2019

  1. add tests for consul connect validation

    Mahmood Ali committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    766f1bf View commit details
    Browse the repository at this point in the history

  2. consul connect: do basic validation before mutating job 

    `groupConnectHook` assumes that Networks is a non-empty slice, but TG
hasn't been validated yet and validation may depend on mutation results.
As such, we do basic check here before dereferencing network slice
elements.
    Mahmood Ali committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    51484bf View commit details
    Browse the repository at this point in the history

  3. Fix admissionValidators 

    `admissionValidators` doesn't aggregate errors correctly, as it
aggregates errors in `errs` reference yet it always returns the nil
`err`.

Here, we avoid shadowing `err`, and move variable declarations to where
they are used.
    Mahmood Ali committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    ba7f4fb View commit details
    Browse the repository at this point in the history