Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider devices in tasksUpdated #6647

Merged
merged 4 commits into from
Nov 7, 2019
Merged

Conversation

cgbaker
Copy link
Contributor

@cgbaker cgbaker commented Nov 7, 2019

the scheduler checks whether task changes require a restart, this needed to be updated to consider devices

resolves #6644

@cgbaker cgbaker added this to Triaged in Nomad - Community Issues Triage via automation Nov 7, 2019
@cgbaker cgbaker moved this from Triaged to In Review in Nomad - Community Issues Triage Nov 7, 2019
CHANGELOG.md Outdated Show resolved Hide resolved
scheduler/util_test.go Outdated Show resolved Hide resolved
@schmichael schmichael added this to the 0.10.2 milestone Nov 7, 2019
cgbaker and others added 2 commits November 7, 2019 14:11
Co-Authored-By: Michael Schurter <mschurter@hashicorp.com>
@cgbaker cgbaker requested review from schmichael and endocrimes and removed request for langmartin and endocrimes November 7, 2019 22:41
@cgbaker cgbaker merged commit e715e14 into master Nov 7, 2019
Nomad - Community Issues Triage automation moved this from In Review to Done Nov 7, 2019
@cgbaker cgbaker deleted the b-6644-reschedule-on-device-changes branch November 7, 2019 22:46
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modifying device count doesn't cause scheduling
3 participants