Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove accidental project leakage in api/ package #6685

Merged
merged 4 commits into from
Nov 12, 2019

Conversation

notnoop
Copy link
Contributor

@notnoop notnoop commented Nov 12, 2019

nomad /api package should be divested from rest of nomad, to ease go mod adoption; but looks like we accidentally relied on helper/uuid due to my bad advice in #6650 (comment) .

Removed the accidental complexity, and inlined function to avoid declaring yet another go mod dependency for tests alone.

For some context, go mod treats test dependencies just like regular dependencies; and if github.com/hashicorp/nomad is marked as a dependency, then api users may need to declaring dependency on all of nomad main project transitively, which causes sadness given main app isn't go mod friendly yet and the project dependencies are many and large.

@notnoop notnoop added the theme/api HTTP API and SDK issues label Nov 12, 2019
@notnoop notnoop added this to the 0.10.2 milestone Nov 12, 2019
Copy link
Contributor

@drewbailey drewbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops, thanks for catching/fixing this! Fix makes sense, glad we can check w/ linting

@notnoop notnoop merged commit 1151774 into master Nov 12, 2019
@notnoop notnoop deleted the b-api-separation-20191112 branch November 12, 2019 18:47
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
theme/api HTTP API and SDK issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants