Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new "semver" constraint #6699

Merged
merged 4 commits into from
Nov 19, 2019
Merged

Add new "semver" constraint #6699

merged 4 commits into from
Nov 19, 2019
+670 −47

Commits on Nov 19, 2019

  1. vendor: update go-version to include NewSemver

    @schmichael
    schmichael committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    1d2fa5a View commit details
    Browse the repository at this point in the history

  2. core: add semver constraint 

    The existing version constraint uses logic optimized for package
managers, not schedulers, when checking prereleases:

- 1.3.0-beta1 will *not* satisfy ">= 0.6.1"
- 1.7.0-rc1 will *not* satisfy ">= 1.6.0-beta1"

This is due to package managers wishing to favor final releases over
prereleases.

In a scheduler versions more often represent the earliest release all
required features/APIs are available in a system. Whether the constraint
or the version being evaluated are prereleases has no impact on
ordering.

This commit adds a new constraint - `semver` - which will use Semver
v2.0 ordering when evaluating constraints. Given the above examples:

- 1.3.0-beta1 satisfies ">= 0.6.1" using `semver`
- 1.7.0-rc1 satisfies ">= 1.6.0-beta1" using `semver`

Since existing jobspecs may rely on the old behavior, a new constraint
was added and the implicit Consul Connect and Vault constraints were
updated to use it.
    @schmichael
    schmichael committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    75d6d4e View commit details
    Browse the repository at this point in the history

  3. docs: document semver constraint operator

    @schmichael
    schmichael committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    88a9877 View commit details
    Browse the repository at this point in the history

  4. test: assert semvers are *not* compared lexically

    @schmichael
    schmichael committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    ecd4ed1 View commit details
    Browse the repository at this point in the history