Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: vault integration docs should reference new token_period field #6752

Merged
merged 2 commits into from
Dec 2, 2019
Merged

docs: vault integration docs should reference new token_period field #6752

merged 2 commits into from
Dec 2, 2019

Conversation

shoenig
Copy link
Member

@shoenig shoenig commented Nov 21, 2019

Vault deprecated period in favor of token_period in the context of a Token Role.
https://www.vaultproject.io/api/auth/token/index.html#token_period

This change updates Nomad Vault Integration docs to follow suit

@shoenig shoenig requested a review from notnoop November 21, 2019 20:26
cgbaker
cgbaker reviewed Nov 21, 2019
View reviewed changes
Copy link
Contributor

@cgbaker cgbaker left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a minimum version of Nomad necessary for this new field to work?

scratch that, these are vault payloads.

notnoop
notnoop approved these changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@notnoop notnoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, s/explicit_max_ttl/token_explicit_max_ttl/g for these fields.

I will update changelog too for #6680

@shoenig shoenig merged commit 76c6437 into master Dec 2, 2019
@shoenig shoenig deleted the docs-vault-token_period branch December 2, 2019 21:21
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 24, 2023
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@notnoop notnoop notnoop approved these changes

@cgbaker cgbaker cgbaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shoenig @notnoop @cgbaker