Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: expose allocated CPU per task #6784

Merged
merged 1 commit into from
Dec 9, 2019
Merged

client: expose allocated CPU per task #6784

merged 1 commit into from
Dec 9, 2019

Conversation

hobochili
Copy link
Contributor

Related to #4280 and #5526
Modeled after #5492

Using the currently exposed metrics there is no way to calibrate per-task CPU allocation based on recent usage. This would be helpful, for example, to identify tasks which are greatly over-allocated in terms of CPU.

This PR adds client.allocs.<job>.<group>.<alloc>.<task>.cpu.allocated as a gauge in CPU ticks.

@hashicorp-cla
Copy link

hashicorp-cla commented Nov 27, 2019

CLA assistant check
All committers have signed the CLA.

@hobochili
Copy link
Contributor Author

Looks like the lint-go stage timed out. I'm guessing it's a transient error as make check passes locally. Can someone with write permissions please re-run the test(s)?

Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hobochili! LGTM.

We'll want to come back through and clean up the backwards compat sections for 0.11.0, but if we merge this in now it'll be in the 0.10.3 release, so don't worry about that.

@tgross tgross merged commit bbb6b2a into hashicorp:master Dec 9, 2019
Nomad - Community Issues Triage automation moved this from Triaged to Done Dec 9, 2019
@hobochili hobochili deleted the allocs-cpu-allocated branch December 9, 2019 20:45
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants