Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scheduler: fix panic when preempting and evicting allocs #6792

Merged
merged 4 commits into from
Dec 3, 2019
Merged

scheduler: fix panic when preempting and evicting allocs #6792

merged 4 commits into from
Dec 3, 2019

Commits on Dec 3, 2019

  1. scheduler: fix panic when preempting and evicting 

    Fixes #6787

In ProposedAllocs the proposed alloc slice was being copied while its
contents were not. Since RemoveAllocs nils elements of the proposed
alloc slice and is called twice, it could panic on the second call when
erroneously accessing a nil'd alloc.

The fix is to not copy the proposed alloc slice and pass the slice
returned by the 1st RemoveAllocs call to the 2nd call, thus maintaining
the trimmed length.
    @schmichael
    schmichael committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    6112ad9 View commit details
    Browse the repository at this point in the history

  2. scheduler: update tests with modern error helper

    @schmichael
    schmichael committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    f12bfdb View commit details
    Browse the repository at this point in the history

  3. docs: add #6792 to changelog

    @schmichael
    schmichael committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    41d29a2 View commit details
    Browse the repository at this point in the history

  4. docs: mention #6787 in upgrade guide

    @schmichael
    schmichael committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    4c909cc View commit details
    Browse the repository at this point in the history