Linux executor with cgroup isolation support #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc: @cbednarski @catsby |
| process, err := os.FindProcess(pid) | ||
| // FindProcess doesn't do any checking against the process table so it's | ||
| // unlikely we'll ever see this error. | ||
| // spawnCgroup executes a double fork to start the user command with proper |
|
Overall looks great! At 700+ lines I may have missed some things, but otherwise LGTM |
dadgar
force-pushed
the
cgroups-f-executor
branch
from
20447f6
to
08f790f
Compare
|
LGTM! 👍 |
dadgar
added a commit
that referenced
this pull request
Sep 21, 2015
Linux executor with cgroup isolation support
schmichael
pushed a commit
that referenced
this pull request
Jan 30, 2020
Autopilot enterprise features
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux executor with cgroup isolation support