-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Fix client sorting #6817
Merged
Merged
UI: Fix client sorting #6817
Commits on Dec 6, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 19592c8 - Browse repository at this point
Copy the full SHA 19592c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a2642d - Browse repository at this point
Copy the full SHA 8a2642dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 77f93a9 - Browse repository at this point
Copy the full SHA 77f93a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for f081b7d - Browse repository at this point
Copy the full SHA f081b7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for a8c571e - Browse repository at this point
Copy the full SHA a8c571eView commit details
Commits on Dec 10, 2019
-
Add warning for keyless use of SortableFactory
This less-than-elegant inclusion of the warning in the computed property is necessary because the mixing-in happens as the application is initialised, so having it outside of the computed property causes it to unhelpfully with no context.
Configuration menu - View commit details
-
Copy full SHA for 0131c36 - Browse repository at this point
Copy the full SHA 0131c36View commit details -
Add exclusion of sortable message in testing
This seems unhelpful to have printed repeatedly in tests.
Configuration menu - View commit details
-
Copy full SHA for ba6a758 - Browse repository at this point
Copy the full SHA ba6a758View commit details
Commits on Dec 11, 2019
-
Combine state into compositeStatus
These fields only differed by the inclusion of draining, and the existing compositeStatus was only being used in one place. This removes an assertion that was unreliable with certain random circumstances; it checked that the composite status was equal to the node status, but that wasn’t true for draining nodes. It felt okay to remove because testing a generalised replacement would necessitate reproducing the entire computed property and there’s already an assertion that tests the specific “ineligible” composite status.
Configuration menu - View commit details
-
Copy full SHA for ad3863f - Browse repository at this point
Copy the full SHA ad3863fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.