Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fix client sorting #6817

Merged
merged 8 commits into from
Dec 12, 2019
Merged

UI: Fix client sorting #6817

merged 8 commits into from
Dec 12, 2019

Commits on Dec 6, 2019

  1. Configuration menu
    Copy the full SHA
    19592c8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8a2642d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    77f93a9 View commit details
    Browse the repository at this point in the history
  4. Remove incorrect comment

    Sorting starts as descending by default!
    backspace committed Dec 6, 2019
    Configuration menu
    Copy the full SHA
    f081b7d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a8c571e View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2019

  1. Add warning for keyless use of SortableFactory

    This less-than-elegant inclusion of the warning in the computed
    property is necessary because the mixing-in happens as the
    application is initialised, so having it outside of the computed
    property causes it to unhelpfully with no context.
    backspace committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    0131c36 View commit details
    Browse the repository at this point in the history
  2. Add exclusion of sortable message in testing

    This seems unhelpful to have printed repeatedly in tests.
    backspace committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    ba6a758 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2019

  1. Combine state into compositeStatus

    These fields only differed by the inclusion of draining,
    and the existing compositeStatus was only being used in
    one place.
    
    This removes an assertion that was unreliable with
    certain random circumstances; it checked that the
    composite status was equal to the node status, but that
    wasn’t true for draining nodes. It felt okay to remove
    because testing a generalised replacement would
    necessitate reproducing the entire computed property and
    there’s already an assertion that tests the specific
    “ineligible” composite status.
    backspace committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    ad3863f View commit details
    Browse the repository at this point in the history