Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

driver: allow disabling log collection #6820

Merged
merged 2 commits into from
Dec 13, 2019
Merged

Commits on Dec 8, 2019

  1. driver: allow disabling log collection

    Operators commonly have docker logs aggregated using various tools and
    don't need nomad to manage their docker logs.  Worse, Nomad uses a
    somewhat heavy docker api call to collect them and it seems to cause
    problems when a client runs hundreds of log collections.
    
    Here we add a knob to disable log aggregation completely for nomad.
    When log collection is disabled, we avoid running logmon and
    docker_logger for the docker tasks in this implementation.
    
    The downside here is once disabled, `nomad logs ...` commands and API
    no longer return logs and operators must corrolate alloc-ids with their
    aggregated log info.
    
    This is meant as a stop gap measure.  Ideally, we'd follow up with at
    least two changes:
    
    First, we should optimize behavior when we can such that operators don't
    need to disable docker log collection.  Potentially by reverting to
    using pre-0.9 syslog aggregation in linux environments, though with
    different trade-offs.
    
    Second, when/if logs are disabled, nomad logs endpoints should lookup
    docker logs api on demand.  This ensures that the cost of log collection
    is paid sparingly.
    Mahmood Ali committed Dec 8, 2019
    Configuration menu
    Copy the full SHA
    9438544 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2019

  1. address review comments

    Mahmood Ali committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    e82dad7 View commit details
    Browse the repository at this point in the history