Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remote agent pprof endpoints #6841

Merged
merged 21 commits into from
Jan 10, 2020
Merged

Remote agent pprof endpoints #6841

merged 21 commits into from
Jan 10, 2020

Commits on Jan 9, 2020

  1. agent pprof endpoints 

    wip, agent endpoint and client endpoint for pprof profiles

agent endpoint test
    @drewbailey
    drewbailey committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    240c0ee View commit details
    Browse the repository at this point in the history

  2. test for known pprof endpoints

    @drewbailey
    drewbailey committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    3575f17 View commit details
    Browse the repository at this point in the history

  3. Server request forwarding for Agent.Profile 

    Return rpc errors for profile requests, set up remote forwarding to
target leader or server id for profile requests.

server forwarding, endpoint tests
    @drewbailey
    drewbailey committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    fb1b4cd View commit details
    Browse the repository at this point in the history

  4. acl and debug test table 

    rename implementation method
    @drewbailey
    drewbailey committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    d077cfe View commit details
    Browse the repository at this point in the history

  5. warn when enabled debug is on when registering 

    m -> a receiver name

return codederrors, fix query
    @drewbailey
    drewbailey committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    c28e5ad View commit details
    Browse the repository at this point in the history

  6. test pprof headers and profile methods 

    tidy up, add comments

clean up seconds param assignment
    @drewbailey
    drewbailey committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    57dc0c6 View commit details
    Browse the repository at this point in the history

  7. api agent endpoints 

    helper func to return serverPart based off of serverID
    @drewbailey
    drewbailey committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    b0410a4 View commit details
    Browse the repository at this point in the history

  8. move shared structs out of client and into nomad

    @drewbailey
    drewbailey committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    390e22e View commit details
    Browse the repository at this point in the history

  9. region forwarding; prevent recursive forwards for impossible requests 

    prevent region forwarding loop, backfill tests

fix failing test
    @drewbailey
    drewbailey committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    3280755 View commit details
    Browse the repository at this point in the history

  10. rename forward func, add comment for why we forward

    @drewbailey
    drewbailey committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    6e62434 View commit details
    Browse the repository at this point in the history

  11. api docs for agent/pprof

    @drewbailey
    drewbailey committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    588b34c View commit details
    Browse the repository at this point in the history

  12. RPC server EnableDebug option 

    Passes in agent enable_debug config to nomad server and client configs.
This allows for rpc endpoints to have more granular control if they
should be enabled or not in combination with ACLs.

enable debug on client test
    @drewbailey
    drewbailey committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    d77b5ad View commit details
    Browse the repository at this point in the history

  13. prevent doubly wrapping with rpc error

    @drewbailey
    drewbailey committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    11563dc View commit details
    Browse the repository at this point in the history

  14. provide helpful error, cleanup logic

    @drewbailey
    drewbailey committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    db382d3 View commit details
    Browse the repository at this point in the history

  15. leave acl checking to rpc endpoints 

    fix test expectation

test wrapNonJSON
    @drewbailey
    drewbailey committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    a3f73b3 View commit details
    Browse the repository at this point in the history

  16. comments for api usage of agent profile

    @drewbailey
    drewbailey committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    cd7652f View commit details
    Browse the repository at this point in the history

  17. address pr feedback

    @drewbailey
    drewbailey committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    1776458 View commit details
    Browse the repository at this point in the history

  18. Rename profile package to pprof 

    Address pr feedback, rename profile package to pprof to more accurately
describe its purpose. Adds gc param for heap lookup profiles.
    @drewbailey
    drewbailey committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    549045f View commit details
    Browse the repository at this point in the history

  19. condense table test

    @drewbailey
    drewbailey committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    2826508 View commit details
    Browse the repository at this point in the history

  20. adds qc param, address pr feedback

    @drewbailey
    drewbailey committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    ad86438 View commit details
    Browse the repository at this point in the history

  21. refactor api profile methods 

    comment why we ignore errors parsing params
    @drewbailey
    drewbailey committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    a58b8a5 View commit details
    Browse the repository at this point in the history