-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle Upgrades and Alloc.TaskResources modification #6922
Commits on Jan 8, 2020
-
CLI: protect against AllocatedResources being nil
Mahmood Ali committedJan 8, 2020 Configuration menu - View commit details
-
Copy full SHA for db49137 - Browse repository at this point
Copy the full SHA db49137View commit details
Commits on Jan 9, 2020
-
Migrate old alloc structs on read
This commit ensures that Alloc.AllocatedResources is properly populated when read from persistence stores (namely Raft and client state store). The alloc struct may have been written previously by an arbitrary old version that may only populate Alloc.TaskResources.
Mahmood Ali committedJan 9, 2020 Configuration menu - View commit details
-
Copy full SHA for 7783c13 - Browse repository at this point
Copy the full SHA 7783c13View commit details -
client: canonicalize alloc runner on RPC
Mahmood Ali committedJan 9, 2020 Configuration menu - View commit details
-
Copy full SHA for 0a5fd78 - Browse repository at this point
Copy the full SHA 0a5fd78View commit details -
client: stop using alloc.TaskResources
Now that alloc.Canonicalize() is called in all alloc sources in the client (i.e. on state restore and RPC fetching), we no longer need to check alloc.TaskResources. alloc.AllocatedResources is always non-nil through alloc runner. Though, early on, we check for alloc validity, so NewTaskRunner and TaskEnv must still check. `TestClient_AddAllocError` test validates that behavior.
Mahmood Ali committedJan 9, 2020 Configuration menu - View commit details
-
Copy full SHA for 058076a - Browse repository at this point
Copy the full SHA 058076aView commit details
Commits on Jan 10, 2020
-
canonicalize allocs from plan results too
Mahmood Ali committedJan 10, 2020 Configuration menu - View commit details
-
Copy full SHA for 4f36d4b - Browse repository at this point
Copy the full SHA 4f36d4bView commit details
Commits on Jan 15, 2020
-
Mahmood Ali committed
Jan 15, 2020 Configuration menu - View commit details
-
Copy full SHA for 3291523 - Browse repository at this point
Copy the full SHA 3291523View commit details -
actually always canonicalize alloc.Job
alloc.Job may be stale as well and need to migrate it. It does cost extra cycles but should be negligible.
Mahmood Ali committedJan 15, 2020 Configuration menu - View commit details
-
Copy full SHA for 4813863 - Browse repository at this point
Copy the full SHA 4813863View commit details
Commits on Jan 28, 2020
-
client: canonicalize alloc.Job on restore
There is a case for always canonicalizing alloc.Job field when canonicalizing the alloc. I'm less certain of implications though, and the job canonicalize hasn't changed for a long time. Here, we special case client restore from database as it's probably the most relevant part. When receiving an alloc from RPC, the data should be fresh enough.
Mahmood Ali committedJan 28, 2020 Configuration menu - View commit details
-
Copy full SHA for 438f98c - Browse repository at this point
Copy the full SHA 438f98cView commit details -
tests: run_for is already a string
Mahmood Ali committedJan 28, 2020 Configuration menu - View commit details
-
Copy full SHA for 99bc650 - Browse repository at this point
Copy the full SHA 99bc650View commit details