Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System sched ignore ineligible updates #6996

Merged
merged 5 commits into from
Feb 3, 2020
Merged

System sched ignore ineligible updates #6996

merged 5 commits into from
Feb 3, 2020

Commits on Feb 3, 2020

  1. ignore computed diffs if node is ineligible 

    test flakey, add temp sleeps for debugging

fix computed class
    @drewbailey
    drewbailey committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    580baea View commit details
    Browse the repository at this point in the history

  2. make diffSystemAllocsForNode aware of eligibility 

    diffSystemAllocs -> diffSystemAllocsForNode, this function is only used
for diffing system allocations, but lacked awareness of eligible
nodes and the node ID that the allocation was going to be placed.

This change now ignores a change if its existing allocation is on an
ineligible node. For a new allocation, it also checks tainted and
ineligible nodes in the same function instead of nil-ing out the diff
after computation in diffSystemAllocs
    @drewbailey
    drewbailey committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    cd00d6d View commit details
    Browse the repository at this point in the history

  3. add test for node eligibility

    @drewbailey
    drewbailey committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    92f0a34 View commit details
    Browse the repository at this point in the history

  4. comment for filtering reason

    @drewbailey
    drewbailey committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    a880d75 View commit details
    Browse the repository at this point in the history

  5. update changelog

    @drewbailey
    drewbailey committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    e86988c View commit details
    Browse the repository at this point in the history