Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: Use MultiplexV2 for connections #7044

Merged
merged 2 commits into from
Feb 13, 2020
Merged

rpc: Use MultiplexV2 for connections #7044

merged 2 commits into from
Feb 13, 2020

Commits on Feb 4, 2020

  1. rpc: Use MultiplexV2 for connections

    MultiplexV2 is a new connection multiplex header that supports multiplex both
    RPC and streaming requests over the same Yamux connection.
    
    MultiplexV2 was added in 0.8.0 as part of
    #3892 .  So Nomad 0.11 can expect it to
    be supported.  Though, some more rigorous testing is required before merging
    this.
    
    I want to call out some implementation details:
    
    First, the current connection pool reuses the Yamux stream for multiple RPC calls,
    and doesn't close them until an error is encountered.  This commit doesn't
    change it, and sets the `RpcNomad` byte only at stream creation.
    
    Second, the StreamingRPC session gets closed by callers and cannot be reused.
    Every StreamingRPC opens a new Yamux session.
    Mahmood Ali committed Feb 4, 2020
    2 Configuration menu
    Copy the full SHA
    7144efe View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2020

  1. Update helper/pool/pool.go

    Co-Authored-By: Michael Schurter <mschurter@hashicorp.com>
    Mahmood Ali and schmichael committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    cac99e1 View commit details
    Browse the repository at this point in the history