Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consul/connect: in-place update sidecar service registrations on changes #7192

Merged
merged 2 commits into from
Feb 21, 2020
Merged

consul/connect: in-place update sidecar service registrations on changes #7192

merged 2 commits into from
Feb 21, 2020

Commits on Feb 19, 2020

  1. consul/connect: in-place update sidecar service registrations on changes 

    Fix a bug where consul service definitions would not be updated if changes
were made to the service in the Nomad job. Currently this only fixes the
bug for cases where the fix is a matter of updating consul agent's service
registration. There is related bug where destructive changes are required
(see #6877) which will be fixed in another PR.

The enable_tag_override configuration setting for the parent service is
applied to the sidecar service.

Fixes #6459
    @shoenig
    shoenig committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    1225afb View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2020

  1. nomad: note why AddressMode is not part of CSD hash 

    Co-Authored-By: Michael Schurter <mschurter@hashicorp.com>
    @shoenig @schmichael
    shoenig and schmichael authored Feb 21, 2020
    Configuration menu
    Copy the full SHA
    cfe5e9f View commit details
    Browse the repository at this point in the history