Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: alloc exec recovers from bad client connection #7274

Merged
merged 1 commit into from
Mar 5, 2020
Merged

api: alloc exec recovers from bad client connection #7274

merged 1 commit into from
Mar 5, 2020

Commits on Mar 4, 2020

  1. api: alloc exec recovers from bad client connection 

    If alloc exec fails to connect to the nomad client associated with the
alloc, fail over to using a server.

The code attempted to special case `net.Error` for failover to rule out
other permanent non-networking errors, by reusing a pattern in the
logging handling.

But this pattern does not apply here.  `net/http.Http` wraps all errors
as `*url.Error` that is net.Error.  The websocket doesn't, and instead
returns the raw error.  If the raw error isn't a `net.Error`, like in
the case of TLS handshake errors, the api package would fail immediately
rather than failover.
    Mahmood Ali committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    c50f295 View commit details
    Browse the repository at this point in the history